USDC v3 #338
USDC v3 #338
Conversation
| "ERC20: transfer amount exceeds allowance" | ||
| ); | ||
| _transfer(from, to, value); | ||
| allowed[from][msg.sender] = allowed[from][msg.sender].sub(value); |
There was a problem hiding this comment.
While you're at it, can save 5k more gas on swaps and contract interactions by using infinite approval gas optimization!!
Something like this:
| allowed[from][msg.sender] = allowed[from][msg.sender].sub(value); | |
| if (allowed[from][msg.sender] != uint(-1)) { | |
| allowed[from][msg.sender] = allowed[from][msg.sender].sub(value); | |
| } |
Reference
There was a problem hiding this comment.
in this moment I am euphoric
There was a problem hiding this comment.
@phil-ociraptor in your suggestion aren't you missing a ]?
L121 of your suggestion 👇
if (allowed[from][msg.sender] != uint(-1)) {
|
Thanks for the PR, this is really cool. We would really love to reduce gas fees. At this point though I'm not sure we can get rid of the blacklist functionality as-is. Such change will require a broader discussion including legal and regulatory compliance teams. Packing it into the high bit as you suggested https://twitter.com/alex_kroeger/status/1485756038502510593?s=21 might be more appealing as it preserves the existing functionality and should provide similar gas savings. |
USDC v3 reduces gas costs for users by replacing blacklist checks on
transfer,transferFrom, andapprovewith afreezeBalanceadmin function.Please check out this post on mirror.xyz for more context about these proposed changes.